Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argo-controller: Add executor-image to config #125

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

orfeas-k
Copy link
Contributor

Add executor-image field in the charm's config file in order to avoid deducing it based on the tag of the container image.

Closes #115

Add executor-image field in the charm's config file in order to avoid
deducing it based on the tag of the container image.

Closes #115
Copy link
Contributor

@i-chvets i-chvets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All conversations are resolved. Approved.

@orfeas-k orfeas-k merged commit 3c600d0 into main Aug 29, 2023
@orfeas-k orfeas-k deleted the kf-4153-argo-controller-executor-image branch August 29, 2023 13:50
@phoevos phoevos mentioned this pull request Sep 1, 2023
i-chvets pushed a commit that referenced this pull request Sep 22, 2023
Summary of changes:
- Ported configuration of executor image configuration.
- Issue: #115
- PR on main: #125
i-chvets added a commit that referenced this pull request Sep 22, 2023
Summary of changes:
- Ported configuration of executor image configuration.
- Issue: #115
- PR on main: #125
i-chvets added a commit that referenced this pull request Sep 27, 2023
* fix: ported exec image config

Summary of changes:
- Ported configuration of executor image configuration.
- Issue: #115
- PR on main: #125

* fix: updated image with reference to rock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charm is deducing the executor tag based on the tag of the controller image
2 participants