Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update craft-application and craft-providers #2069

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Jan 8, 2025

Use a unique build environment for each platform in a charm recipe.

Scenario 1

  • Fixes a bug where multiple platforms would build in the same build environment if the platforms had the same build-on and build-for entries.
platforms:
  noble:
      build-on: [riscv64]
      build-for: [riscv64]
  noble-debug:
      build-on: [riscv64]
      build-for: [riscv64]

Scenario 2

  • Improves build time for multi-base recipes. Previously, Charmcraft would tear down and recreate the same container when building for a different base if the platforms had the same build-on and build-for entries.
platforms:
  jammy:
      build-on: [ubuntu@22.04:riscv64]
      build-for: [ubuntu@22.04:riscv64]
  noble:
      build-on: [ubuntu@24.04:riscv64]
      build-for: [ubuntu@24.04:riscv64]

Fixes #2058
(CRAFT-3847)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3847-build-env-per-platform branch from be6d7d2 to 0618c6c Compare January 13, 2025 19:08
@mr-cal mr-cal changed the title fix: use unique build environments per platform build(deps): update craft-application and craft-providers Jan 13, 2025
@mr-cal mr-cal marked this pull request as ready for review January 13, 2025 21:36
@mr-cal mr-cal requested a review from lengau as a code owner January 13, 2025 21:36
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lengau lengau merged commit f65ecc0 into main Jan 14, 2025
27 of 28 checks passed
@lengau lengau deleted the work/CRAFT-3847-build-env-per-platform branch January 14, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-base charm uses same LXC container for different bases
2 participants