Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suspend stats related check (Bugfix) #1700

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hanhsuan
Copy link
Contributor

@hanhsuan hanhsuan commented Jan 24, 2025

Description

WARNING: This modifies com.canonical.certification::sru-server

According to the suspend_advanced_auto is the dependency for all after suspend jobs, it would be better to do more tests for this concept to fix #1579.
Therefore, this PR is the first step to collect information by:

  1. valid_suspend_status is used to check success should be non zero
  2. any_fail_during_supend is used to check fail should be zero

If everything woks well, valid_suspend_status will be merge into suspend_advanced_auto in the future.

Resolved issues

#1579

Documentation

Tests

succ 202001-27667
fail 202412-36131

1. test case is_suspend_success will be merged into
   suspend_advanced_auto
2. is_device_supend_success is used to check any fail
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.06%. Comparing base (e5b7c6f) to head (3684954).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/suspend_stats.py 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
+ Coverage   49.01%   49.06%   +0.05%     
==========================================
  Files         372      373       +1     
  Lines       40348    40392      +44     
  Branches     6817     6827      +10     
==========================================
+ Hits        19777    19819      +42     
- Misses      19849    19851       +2     
  Partials      722      722              
Flag Coverage Δ
provider-base 24.99% <95.45%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanhsuan hanhsuan marked this pull request as ready for review January 24, 2025 05:38
@hanhsuan hanhsuan changed the title Add suspend stats releated check (Bugfix) Add suspend stats related check (Bugfix) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suspend/suspend_advanced_auto always returns passed result
2 participants