chore: add exceptions for stdlib module shadowing #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dariuszd21
approved these changes
Jan 10, 2025
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
lengau
approved these changes
Jan 13, 2025
mr-cal
added a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
added a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
added a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?New ruff is flagging https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/
Renaming these modules feels like an API breakage, so I added exceptions.