requirements: Pin selenium version to 4.10.x #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
force-pushed
the
pin-selenium-version
branch
from
de67a7b to
8e15471
Compare
Pinning to <4.11 because upgrading to 4.11.2 results in chrome version compatibility issue. See #151.
orfeas-k
force-pushed
the
pin-selenium-version
branch
from
8e15471 to
0a5b1c0
Compare
|
@DnPlas thanks for the comments, I had actually missed those. Force pushed onto the branch. |
DnPlas
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin Selenium version to
<4.11in charm's integration tests because upgrading to4.11.2results in the following issue #151.Related runs
https://github.com/canonical/dex-auth-operator/actions/runs/5763096636/job/15669866245?pr=132#step:5:2253
https://github.com/canonical/dex-auth-operator/actions/runs/5763096636/job/15627005664?pr=132#step:5:2066