Skip to content

Conversation

@erinecon
Copy link
Contributor

Closes #140

Removed rule 001 as it's superfluous with spelling rules.

I verified that the tests still pass locally despite the removal of the rule.

Copy link
Contributor

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erinecon Shouldn't this also remove the following line from vale.ini?

Canonical.001-English-words-spelling-suggestions  = suggest

@erinecon
Copy link
Contributor Author

Shouldn't this also remove the following line from vale.ini?

Hi @rkratky , you're absolutely right. Thank you so much for catching it!!

@erinecon erinecon requested a review from rkratky December 12, 2025 16:56
SecondSkoll
SecondSkoll previously approved these changes Dec 15, 2025
Copy link
Contributor

@AnneCYH AnneCYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and makes sense to remove this.
The only thing that is 'missing' is the "suggestions"; but then again i don't know how helpful those are for our users.

Thanks!

@erinecon erinecon merged commit 4340f97 into main Dec 16, 2025
2 checks passed
@erinecon erinecon deleted the remove-rule-001 branch December 16, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove rule: 001-English-words-spelling-suggestions.yml

6 participants