Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce ingress relation #62

Merged
merged 14 commits into from
Oct 25, 2023
Merged

feat: Introduce ingress relation #62

merged 14 commits into from
Oct 25, 2023

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Oct 20, 2023 •
edited
Loading

  • Introduce ingress relation so that a virtualService can be created pointing to the envoy's service and UI components can access it using the gRPC-Web protocol.
  • Add ingress relation unit and integration test

Fixes #61

@orfeas-k
Introduce ingress relation
72e6d04 
Introduce ingress relation so that there is a virtualService pointing to
the workload's service and UI components can access it via gRPC-Web
protocol.
@orfeas-k
tests(integration): Add test_virtual_service
d457ae0 
- Assert that virtual service exists
- Assert that the right endpoint is served
@orfeas-k
tests(unit): refactor
ecd057f
@orfeas-k
tests(unit): Add ingress relation test
a615110
@orfeas-k orfeas-k requested a review from a team as a code owner October 20, 2023 08:48
@orfeas-k orfeas-k force-pushed the kf-4869-envoy-virtual-service branch 2 times, most recently from 72e4fda to 3be5bc5 Compare October 20, 2023 10:40
@orfeas-k orfeas-k force-pushed the kf-4869-envoy-virtual-service branch from 3be5bc5 to 8b58bed Compare October 20, 2023 11:39
misohu
misohu reviewed Oct 23, 2023
View reviewed changes
tests/integration/test_charm.py Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Show resolved Hide resolved
DnPlas
DnPlas reviewed Oct 23, 2023
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
DnPlas
DnPlas reviewed Oct 23, 2023
View reviewed changes
src/charm.py Show resolved Hide resolved
DnPlas
DnPlas reviewed Oct 25, 2023
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
DnPlas
DnPlas reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny little comment, other than that LGTM.

misohu
misohu approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM wait for CI to pas please :)

@orfeas-k orfeas-k merged commit 8bd8013 into main Oct 25, 2023
7 checks passed
@orfeas-k orfeas-k deleted the kf-4869-envoy-virtual-service branch October 25, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas left review comments

@misohu misohu misohu approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

envoy needs a virtualService to be accessible by UI components via gRPC-Web
3 participants
@orfeas-k @misohu @DnPlas