Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update envoy configuration #64

Merged
merged 3 commits into from
Oct 27, 2023
Merged

fix: Update envoy configuration #64

merged 3 commits into from
Oct 27, 2023

Conversation

orfeas-k
Copy link
Contributor

Details in #63.

  • Update envoy configuration to:
    • include empty value for static.resources.http2_protocol_options field since this must be set.
    • revert max_grpc_timeout to 60 (a large enough timeout). Setting it to 0 resulted in the SDK not
      rendering it. When this value is empty, envoy uses timeout's default value which is 15s, while
      upstream has set this to 0, meaning that there is no timeout.
    • Rename listener to listener_0 in order to not diverge from upstream without a reason.
  • Update to use the image built from this Dockerfile in order to not diverge from upstream without a
    reason. Since we define the command ourselves in the charm, the different cmd shouldn't bite us.

Fixes #63

@orfeas-k
chore: bump image for CKF 1.8
88796bb 
Update image to the one upstream pipelines use for envoy in order to not
diverge.
@orfeas-k
fix: Update envoy configuration
80b8135
@orfeas-k orfeas-k requested a review from a team as a code owner October 27, 2023 09:43
DnPlas
DnPlas reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment, other than that LGTM! Thanks @orfeas-k

src/charm.py Show resolved Hide resolved
DnPlas
DnPlas approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just confirmed this works! LGTM! Great job @orfeas-k !

image

@orfeas-k orfeas-k merged commit 130ed56 into main Oct 27, 2023
7 checks passed
@orfeas-k orfeas-k deleted the kf-4934-fix-envoy-configuration branch October 27, 2023 11:30
@orfeas-k orfeas-k mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

envoy responds upstream connect error: connection termination
2 participants
@orfeas-k @DnPlas