-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite to sidecar using CharmReconciler #75
Conversation
This PR refactors the PodSpec charm to sidecar using the CharmReconciler. Changes include: * converting all charm logic to use Components * removing the unused grpc-web relation * bumping charmed-kubeflow-chisme to 0.3.0
# Conflicts: # requirements-integration.txt # requirements-unit.txt # requirements.txt
I think the creds need to be fixed in the repo. Will investigate tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ca-scribner, this is looking good already, just a couple comments.
c24fb87
to
22d3628
Compare
Also removes old commented out test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few comments, thanks @ca-scribner !
This PR refactors the PodSpec charm to sidecar using the CharmReconciler. Changes include:
Closes #71