Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to sidecar using CharmReconciler #75

Merged
merged 15 commits into from
Apr 3, 2024
Merged

Conversation

ca-scribner
Copy link
Contributor

This PR refactors the PodSpec charm to sidecar using the CharmReconciler. Changes include:

  • converting all charm logic to use Components
  • removing the unused grpc-web relation
  • bumping charmed-kubeflow-chisme to 0.3.0

Closes #71

This PR refactors the PodSpec charm to sidecar using the CharmReconciler.  Changes include:
* converting all charm logic to use Components
* removing the unused grpc-web relation
* bumping charmed-kubeflow-chisme to 0.3.0
@ca-scribner ca-scribner requested a review from a team as a code owner March 20, 2024 20:10
# Conflicts:
#	requirements-integration.txt
#	requirements-unit.txt
#	requirements.txt
@ca-scribner
Copy link
Contributor Author

I think the creds need to be fixed in the repo. Will investigate tomorrow

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ca-scribner, this is looking good already, just a couple comments.

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
@ca-scribner ca-scribner force-pushed the KF-5257-sidecar-rewrite branch from c24fb87 to 22d3628 Compare March 21, 2024 13:41
@ca-scribner
Copy link
Contributor Author

ca-scribner commented Mar 21, 2024

publishing in this repo is still broken, but I’ll resolve that as a separate PR
fixed. repo had expired or invalid credentials

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments, thanks @ca-scribner !

tests/unit/test_charm.py Show resolved Hide resolved
tests/unit/test_charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@ca-scribner ca-scribner enabled auto-merge (squash) March 25, 2024 20:54
@ca-scribner ca-scribner merged commit c3376ab into main Apr 3, 2024
7 checks passed
@ca-scribner ca-scribner deleted the KF-5257-sidecar-rewrite branch April 3, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidecar rewrite: envoy
2 participants