Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setuptools breaking dep issue #50

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix setuptools breaking dep issue #50

merged 1 commit into from
Jul 30, 2024

Conversation

yanksyoon
Copy link
Contributor

The recent release of setuptools is not compatible with dogpile lib which breaks charmcraft because it tries to build everything from source.
Just use binary version of these tools.

@yanksyoon yanksyoon requested a review from a team as a code owner July 29, 2024 15:54
Copy link

Test coverage for 54287c8

Name                             Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------
src/charm.py                        52      3      4      1    93%   98-100
src/charm_state.py                  35      1      8      1    95%   21
src/constants.py                     4      0      0      0   100%
src/exceptions.py                    3      0      0      0   100%
src/github_actions_exporter.py      23      0      0      0   100%
----------------------------------------------------------------------------
TOTAL                              117      4     12      2    95%

Static code analysis report

Run started:2024-07-29 15:56:33.959989

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 587
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@amandahla amandahla merged commit 2c5681e into main Jul 30, 2024
17 checks passed
@amandahla amandahla deleted the fix/build branch July 30, 2024 20:42
@amandahla
Copy link
Collaborator

Thanks @yanksyoon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants