-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prometheus_scrape integration by adding prometheus_alert_rules #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merkata
previously approved these changes
Sep 14, 2023
Please provide an explanation for anything that is not checked on the checklist |
Test coverage for 00eb40d
Static code analysis report
|
nrobinaubertin
approved these changes
Sep 15, 2023
merkata
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If there is no prometheus_alert_rules the charm fails with "Invalid Prometheus alert rules folder at /var/lib/juju/agents/unit-github-actions-exporter-0/charm/src/prometheus_alert_rules: directory does not exist"
This PR fixes it, update the library and add a temporary docs field to charmcraft run as expected.
Rationale
This way the charm can integrate with the Prometheus charm as expected.
Juju Events Changes
N/A
Module Changes
N/A
Library Changes
N/A
Checklist
src-docs
urgent
,trivial
,complex
)There is no src-docs for this charm.
There is no charmhub documentation for this charm.