Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add separate CI worflows to run library tests and linting #224

Merged

Conversation

BarcoMasile
Copy link
Contributor

@BarcoMasile BarcoMasile commented Mar 18, 2024

Description

This PR creates a separate CI workflow for the library folder reback-admin-backend.
It performes linting and runs unit tests. Right now the action runs on both merges on branch feature-reback-admin-ui-backend and on all opened pull requests. When the folder will be extracted only filenames and relative usages of their path will need to be changed.

Changes

For the linting, I used golangci-lint github action with latest version and the working-directory set to the library folder rebac-admin-backend.
For unit tests, I just run make test.

@BarcoMasile BarcoMasile force-pushed the IAM-695-ci/endpoints-library-tests branch 5 times, most recently from 6d828b6 to c53a983 Compare March 18, 2024 14:56
@BarcoMasile BarcoMasile force-pushed the IAM-695-ci/endpoints-library-tests branch from c53a983 to ee991c9 Compare March 18, 2024 14:59
@BarcoMasile BarcoMasile marked this pull request as ready for review March 18, 2024 15:00
@BarcoMasile BarcoMasile requested a review from a team as a code owner March 18, 2024 15:00
.github/workflows/rebac-admin-backend-lint.yaml Outdated Show resolved Hide resolved
.github/workflows/rebac-admin-backend-unittest.yaml Outdated Show resolved Hide resolved
rebac-admin-backend/Makefile Outdated Show resolved Hide resolved
rebac-admin-backend/Makefile Outdated Show resolved Hide resolved
rebac-admin-backend/Makefile Outdated Show resolved Hide resolved
rebac-admin-backend/Makefile Show resolved Hide resolved
@BarcoMasile BarcoMasile force-pushed the IAM-695-ci/endpoints-library-tests branch from 3fa5415 to fb19d10 Compare March 19, 2024 10:34
@BarcoMasile BarcoMasile merged commit 7f53271 into feature-rebac-admin-ui-backend Mar 19, 2024
6 checks passed
@BarcoMasile BarcoMasile deleted the IAM-695-ci/endpoints-library-tests branch March 19, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants