IAM 974 #414
Merged
IAM 974 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shipperizer
commented
Sep 16, 2024
shipperizer
commented
- fix: drop ctx param from NewV1Service creation
- feat: wire up all the rebac handlers
- fix: add uri permissions converters for v1
|
#387 will address some of the TODOs in the pr |
nsklikas
previously approved these changes
Sep 16, 2024
wood-push-melon
previously approved these changes
Sep 17, 2024
BarcoMasile
previously approved these changes
Sep 18, 2024
shipperizer
dismissed stale reviews from BarcoMasile, wood-push-melon, and nsklikas
via
9e59915
shipperizer
force-pushed
the
IAM-974
branch
from
21e4c5b
to
9e59915
Compare
shipperizer
requested review from
BarcoMasile,
wood-push-melon and
nsklikas
BarcoMasile
approved these changes
Sep 18, 2024
wood-push-melon
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.