-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epa howto #658
Epa howto #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Formatting issue prevents me from continuing the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments, thanks for making this doc shiny @evilnick!
Co-authored-by: Louise K. Schmidtgen <louise.schmidtgen@canonical.com>
Co-authored-by: Louise K. Schmidtgen <louise.schmidtgen@canonical.com>
Co-authored-by: Louise K. Schmidtgen <louise.schmidtgen@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need another cup of tea! I've left a lot of comments on the docs. Please remind me to have another look once you've addressed the markdown render issues in the later section of the doc.
Please consider thinking about breaking this doc up into more than one page under an epa folder.
Thank you for tackling this huge Doc!
Co-authored-by: Louise K. Schmidtgen <louise.schmidtgen@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - only a couple of nit comments. Feel free to ignore them
2519611
to
6748308
Compare
* Add more sections to the CAPI docs * Address comments
--------- Co-authored-by: Nick Veitch <nick.veitch@canonical.com>
Co-authored-by: neoaggelos <1888650+neoaggelos@users.noreply.github.com>
At the moment, the "k8sd cluster-recover" displays interactive prompts and text editors that assist the user in updating the dqlite configuration. We need to be able to run the command non-interactively in order to automate the cluster recovery procedure. This change adds a "--non-interactive" flag. If set, we'll no longer show confirmation prompts and we'll assume that the configuration files have already been updated, proceeding with the dqlite recovery.
Co-authored-by: addyess <10090033+addyess@users.noreply.github.com>
--------- Co-authored-by: Yanisa Haley Scherber <yhscherber@gmail.com>
* Automerge every 4-hours any PR with passing tests labeled with 'automerge' * Make sure the bot can approve the PRs too * Update Bot information only if git email currently unset * consistently use private key secret to setup ssh git-remote * Rename secret to BOT_SSH_KEY * Reimagine auto-merge scripts as python
Warnings that k8s service may not work (#657) KU-1475
This is the epa howto. there are a few questions to address and actually some tidying up still to be done (hence draft), but it is completed enough to start looking over and reviewing