Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rock for net-istio-webhook #4

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Add rock for net-istio-webhook #4

merged 5 commits into from
Nov 12, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Nov 12, 2024

Closes: canonical/knative-operators#237

This Rock is based on upstream ko image: https://console.cloud.google.com/gcr/images/knative-releases/GLOBAL/knative.dev/net-istio/cmd/webhook

To compare the rock I was using the latest upstream docker tag v1.12.3 (that is also the version we are using in knative in kubeflow 1.9 bundle).

Steps for local comparison test

# build the ROCK
rockcraft clean && rockcraft pack --verbosity=trace
sudo rockcraft.skopeo --insecure-policy copy oci-archive:net-istio-webhook_v1.12.3_amd64.rock docker-daemon:net-istio-webhook:v1.12.3

# Upstream image 
docker run gcr.io/knative-releases/knative.dev/net-istio/cmd/webhook:v1.12.3

## Output
2024/11/12 08:27:01 Error building kubeconfig: failed to create client config: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

########################################################

# Rock 
docker run net-istio-webhook:v1.12.3

# Output
2024-11-12T08:27:57.781Z [pebble] Started daemon.
2024-11-12T08:27:57.815Z [pebble] POST /v1/services 16.172341ms 202
2024-11-12T08:27:57.832Z [pebble] Service "net-istio-webhook" starting: /ko-app/webhook
2024-11-12T08:27:57.975Z [pebble] Change 1 task (Start service "net-istio-webhook") failed: cannot start service: exited quickly with code 1
2024-11-12T08:27:58.016Z [pebble] GET /v1/changes/1/wait 199.692146ms 200
2024-11-12T08:27:58.017Z [pebble] Started default services with change 1.

# Output for service is hidden you need to get the id of running docker container 
docker ps
# bash into the container 
docker exec -ti <your_id> bash
# execute the service command manually
# Output
2024/11/12 08:29:29 Error building kubeconfig: failed to create client config: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

net-istio-webhook/tox.ini Outdated Show resolved Hide resolved
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All sanity tests pass, and the output is as expected :)

Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but note that we have this issue which blocks us from integration.

@misohu misohu merged commit d622883 into main Nov 12, 2024
7 checks passed
@misohu misohu deleted the KF-6505-net-istio-webhook branch November 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rock for net-istio-webhook
2 participants