Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: canonical/knative-operators#237
This Rock is based on upstream ko image: https://console.cloud.google.com/gcr/images/knative-releases/GLOBAL/knative.dev/net-istio/cmd/webhook
To compare the rock I was using the latest upstream docker tag
v1.12.3
(that is also the version we are using in knative in kubeflow 1.9 bundle).Steps for local comparison test