-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rock for net-istio-controller #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @mvlassis , left you some comments for the code and will test in parallel as you address them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some additional comments based on the ko spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @mvlassis !
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
c428487
to
dca33cb
Compare
Closes canonical/knative-operators#238
This rock is based on the image found here: https://console.cloud.google.com/gcr/images/knative-releases/global/knative.dev/net-istio/cmd/controller
To check that everything is as expected: