Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rock for net-istio-controller #5

Merged
merged 29 commits into from
Nov 20, 2024
Merged

Conversation

mvlassis
Copy link
Contributor

Closes canonical/knative-operators#238

This rock is based on the image found here: https://console.cloud.google.com/gcr/images/knative-releases/global/knative.dev/net-istio/cmd/controller

To check that everything is as expected:

# Clone the repository and checkout to this branch, then cd to the proper subdirectory
cd net-istio-controller

# Build the rock
tox -e pack

# Export to docker
tox -e export-to-docker

# Sanity tests
tox -e sanity

# Compare output with the upstream image

docker run gcr.io/knative-releases/knative.dev/net-istio/cmd/controller:v1.12.3
## Sample output
## Output
2024/11/12 11:27:01 Error building kubeconfig: failed to create client config: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

docker run net-istio-webhook:v1.12.3
# Get the ID of the container
docker ps
# Run bash into it
docker exec -ti <container_id> bash
# Execute the service command manually
/ko-data/controller
## Sample output
# Output
2024/11/12 11:29:29 Error building kubeconfig: failed to create client config: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mvlassis , left you some comments for the code and will test in parallel as you address them.

net-istio-controller/rockcraft.yaml Outdated Show resolved Hide resolved
net-istio-controller/rockcraft.yaml Outdated Show resolved Hide resolved
net-istio-controller/rockcraft.yaml Outdated Show resolved Hide resolved
net-istio-controller/rockcraft.yaml Outdated Show resolved Hide resolved
net-istio-controller/tests/test_rock.py Outdated Show resolved Hide resolved
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some additional comments based on the ko spec

net-istio-controller/rockcraft.yaml Show resolved Hide resolved
net-istio-controller/rockcraft.yaml Show resolved Hide resolved
net-istio-controller/tests/test_rock.py Outdated Show resolved Hide resolved
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mvlassis !

mvlassis and others added 27 commits November 20, 2024 13:52
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
* feat: create rockcraft project for operator
* add sanity tests
* add certs and cert env var
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
@mvlassis mvlassis force-pushed the kf-6509-net-istio-controller branch from c428487 to dca33cb Compare November 20, 2024 12:02
@mvlassis mvlassis merged commit dc35fc7 into main Nov 20, 2024
7 checks passed
@mvlassis mvlassis deleted the kf-6509-net-istio-controller branch November 20, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rock for net-istio-controller/controller image
2 participants