Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespace to the ingress relation data #176

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

ca-scribner
Copy link
Contributor

Enables supporting cross-model ingresses. The ingress relation supports an optional namespace parameter. If not passed, istio-pilot uses its own namespace, which is invalid if istio and dashboard are deployed in different namespaces.

Enables supporting cross-model ingresses
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ca-scribner !

@DnPlas DnPlas merged commit c470cc4 into main Jan 22, 2025
7 checks passed
@DnPlas DnPlas deleted the add-namespace-to-ingress branch January 22, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants