Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use charmedkubeflow/kubeflow-central-dashboard as oci-image #178

Merged
merged 6 commits into from
Feb 18, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Feb 12, 2024

Use the CKF owned image for the charm instead of upstream's.

Fixes #164

Use the CKF owned image for the charm instead of upstream's

Fixes #164
@ca-scribner
Copy link
Contributor

This appears to be failing due to an unrelated charm error

Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change here lgtm, but the charm has an error that blocks the CI from passing. If we decide to merge this, we'll need to separately fix that CI or manually publish the image

src/charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! gj

@DnPlas DnPlas merged commit 2811dcb into main Feb 18, 2024
7 checks passed
@DnPlas DnPlas deleted the KF4392-integrate-rock-image branch February 18, 2024 11:36
DnPlas added a commit that referenced this pull request Mar 1, 2024
)

* chore: use charmedkubeflow/kubeflow-central-dashboard as oci-image

Use the CKF owned image for the charm instead of upstream's.

Fixes #164
DnPlas added a commit that referenced this pull request Mar 1, 2024
chore: use charmedkubeflow/kubeflow-central-dashboard as oci-image (#178)
DnPlas added a commit that referenced this pull request May 22, 2024
DnPlas added a commit that referenced this pull request May 22, 2024
DnPlas added a commit that referenced this pull request May 23, 2024
…image (#178)" (#191)

This reverts commit 2811dcb.

This is a temporal workaround to help avoid #188. This change must be reverted again once the fix for it is available. Please note the fix depends on https://bugs.launchpad.net/juju/+bug/2066517.
DnPlas added a commit that referenced this pull request May 23, 2024
…image (#178)" (#192)

This reverts commit 2ad140e.

This is a temporal workaround to help avoid #188. This change must be reverted again once the fix for it is available. Please note the fix depends on https://bugs.launchpad.net/juju/+bug/2066517.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate ROCK in kubeflow-dashboard-operator
2 participants