-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use charmedkubeflow/kubeflow-central-dashboard as oci-image #178
Conversation
Use the CKF owned image for the charm instead of upstream's Fixes #164
8af733e
to
550905b
Compare
This appears to be failing due to an unrelated charm error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change here lgtm, but the charm has an error that blocks the CI from passing. If we decide to merge this, we'll need to separately fix that CI or manually publish the image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! gj
) * chore: use charmedkubeflow/kubeflow-central-dashboard as oci-image Use the CKF owned image for the charm instead of upstream's. Fixes #164
chore: use charmedkubeflow/kubeflow-central-dashboard as oci-image (#178)
…image (#178)" (#191) This reverts commit 2811dcb. This is a temporal workaround to help avoid #188. This change must be reverted again once the fix for it is available. Please note the fix depends on https://bugs.launchpad.net/juju/+bug/2066517.
…image (#178)" (#192) This reverts commit 2ad140e. This is a temporal workaround to help avoid #188. This change must be reverted again once the fix for it is available. Please note the fix depends on https://bugs.launchpad.net/juju/+bug/2066517.
Use the CKF owned image for the charm instead of upstream's.
Fixes #164