-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci, build: update CI, libraries, python dependencies, and format #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the CI with standard CI configuration (juju, actions, deps) that is shared across multiple repositories. All python dependencies are also updated to their latest working versions. This PR also includes library updates. Finally, some formatting was applied on non-compliant files (copyright, style).
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
Jul 24, 2023
github-actions
bot
added
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
Jul 26, 2023
phoevos
suggested changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget the following:
diff --git a/charms/tensorboard-controller/requirements-lint.in b/charms/tensorboard-controller/requirements-lint.in
index c77cd87..07a4a51 100644
--- a/charms/tensorboard-controller/requirements-lint.in
+++ b/charms/tensorboard-controller/requirements-lint.in
@@ -1,9 +1,8 @@
+black
codespell
-flake8<6
+flake8
flake8-builtins
-# Pinned because `flake8-copyright==0.2.3` is incompatible with `flake8>=6`. Can unpin this
-# when https://github.com/savoirfairelinux/flake8-copyright/pull/20 or a similar fix is released
flake8-copyright
+isort
pep8-naming
pyproject-flake8
--r requirements-fmt.txt
diff --git a/requirements-integration.in b/requirements-integration.in
index a07d242..e1a657e 100644
--- a/requirements-integration.in
+++ b/requirements-integration.in
@@ -1,4 +1,6 @@
# Pinning to <3.0 to ensure compatibility with the 2.9 controller version
# Note: 3.0 is not being maintained anymore
juju<3.0
+pytest
pytest-operator
+pyyaml
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
labels
Jul 26, 2023
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
Jul 26, 2023
phoevos
reviewed
Jul 26, 2023
phoevos
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the CI with standard CI configuration (juju, actions, deps) that is shared across multiple repositories. All python dependencies are also updated to their latest working versions. This PR also includes library updates. Finally, some formatting was applied on non-compliant files (copyright, style).
This change also contains a fix for #84, an issue caused by a missing toolchain in the charm that allows building certain python packages. For more information, please refer to canonical/bundle-kubeflow#648.
Fixes #84
Part of canonical/bundle-kubeflow#648