fix: TELCO-887 Cleanup annotations

[markbeierl]

On remove event, the library needs to also remove the networks annotation, and drop privileges

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• N/A I have made corresponding changes to the documentation
• I have added tests that validate the behaviour of the software
• I validated that new and existing unit tests pass locally with my changes
• N/A Any dependent changes have been merged and published in downstream modules
• I have bumped the version of the library

[Gmerold]

Do we need to do this? We're about to remove the StatefulSet so why do we care to revert the patch on the container?
It's clear that we need to cleanup NADs, which belong to the namespace, but security context and annotations belong to the container we're removing.

[markbeierl]

Do we need to do this? We're about to remove the StatefulSet so why do we care to revert the patch on the container? It's clear that we need to cleanup NADs, which belong to the namespace, but security context and annotations belong to the container we're removing.

We are not necessarily removing the statefulset. If you scale the unit down to 0, and then scale it back up, this prevents the pod from restarting as the annotations cannot be satisfied and Juju loses control of the pod, resulting in the need for --force removal

[markbeierl]

canonical/sdcore-upf-k8s-operator#54

[Gmerold]

Do we need to do this? We're about to remove the StatefulSet so why do we care to revert the patch on the container? It's clear that we need to cleanup NADs, which belong to the namespace, but security context and annotations belong to the container we're removing.

We are not necessarily removing the statefulset. If you scale the unit down to 0, and then scale it back up, this prevents the pod from restarting as the annotations cannot be satisfied and Juju loses control of the pod, resulting in the need for --force removal

Ups :D

[gruyaume]

Looks good besides the nitpick on the unit test name