Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to $HOME for the ceph command #181

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

sabaini
Copy link
Collaborator

@sabaini sabaini commented Aug 10, 2023

For reading certificates, dumping crushmaps and similar operations

For reading certificates, dumping crushmaps and similar operations

Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
@UtkarshBhatthere
Copy link
Contributor

Thanks for the PR! Is it absolutely necessary to have $HOME access... Or a good to have for future implementations ?

@sabaini
Copy link
Collaborator Author

sabaini commented Aug 14, 2023

For various Ceph tools it's required they be able to access the local filesystem, e.g. to configure the dashboard it's required to have it read a cert. Most users would be surprised the tools can't access their $HOME, so following the principle of least surprise we should allow it in my opinion.

There are workarounds which we could document, i.e. move files to places the snap can access by default, but they're not very user friendly, and in keeping with MicroCephs mission of being low barrier to entry I'd think it better to keep it simple

@UtkarshBhatthere
Copy link
Contributor

Sounds and Looks good to me!

@UtkarshBhatthere UtkarshBhatthere merged commit 9f16345 into canonical:main Aug 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants