Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for disk remove issues #235

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

sabaini
Copy link
Collaborator

@sabaini sabaini commented Oct 9, 2023

Fix regexp for stopping OSD services.

Don't treat a failure to stop an OSD service as fatal, might be down already.

Increase default timeout and retries, the default was overly optimistic.

Test cleanup.

Fix regexp for stopping OSD services.

Don't treat a failure to stop an OSD service as fatal, might be down
already.

Increase default timeout and retries, the default was overly
optimistic.

Test cleanup.

Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabaini
Copy link
Collaborator Author

sabaini commented Oct 9, 2023

This should fix #233

@sabaini sabaini merged commit 7b5672b into canonical:main Oct 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants