Return non-zero on "microk8s status" when service is stopped #3975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
microk8s status returns 0 when the server is down.
$ microk8s status --yaml ; echo $?
microk8s is not running, try microk8s start
0
What Should Happen Instead?
I would expect it to return non-zero, so that I don't need to search for text in the output.
This also complicates my life when trying to directly parse its output as yaml.
Closes #3974
Changes
It returns 1 instead of 0 when the server is down.
Testing
I DID NOT TEST MY CHANGES.
Please someone adopt this tiny change and test it for me :)
Possible Regressions
Checklist
Notes