Fix test_platform_prober conditional compilation when x11 or wayland platforms excluded

[Copilot]

Related: Issue mentions build failures when x11 is excluded from MIR_PLATFORM

What's new?

test_platform_prober.cpp unconditionally used MockX11 and Wayland platform code, causing link failures when these platforms weren't built. All platform-specific test code is now properly guarded:

X11 platform guards (#if defined(MIR_BUILD_PLATFORM_X11)):

• Header include: #include <mir/test/doubles/mock_x11.h>
• Test fixture member: testing::NiceMock<mtd::MockX11> x11; in FullProbeStack
• Helper method: enable_host_x11() definition
• Test functions: 2 X11-specific tests

Wayland platform guards (#if defined(MIR_BUILD_PLATFORM_WAYLAND)):

• Helper method: enable_host_wayland() definition
• Test functions: 2 Wayland-specific tests

Combined X11 and Wayland guards (#if defined(MIR_BUILD_PLATFORM_X11) && defined(MIR_BUILD_PLATFORM_WAYLAND)):

• Test functions: 7 tests requiring both platforms

Build system updates:

• Added add_compile_definitions(MIR_BUILD_PLATFORM_WAYLAND) in tests/unit-tests/CMakeLists.txt to define the Wayland platform macro for conditional compilation

Pattern matches existing platform conditionals for GBM_KMS, ATOMIC_KMS, X11, and EGLSTREAM_KMS.

How to test

Build with MIR_PLATFORM excluding x11 - should compile without linker errors. Build with MIR_PLATFORM excluding wayland - should compile without linker errors. Build with both platforms included - all tests should run as before.

Checklist

• Tests added and pass
• Adequate documentation added
• (optional) Added Screenshots or videos

Original prompt

---

This section details on the original issue you should resolve

<issue_title>test_platform_prober assumes the x11 platform is built</issue_title>
<issue_description>When x11 is excluded from MIR_PLATFORM, the tests fail to build:

/usr/bin/ld: tests/unit-tests/CMakeFiles/mir_umock_unit_tests.dir/graphics/test_platform_prober.cpp.o: in function `testing::NiceMock<mir::test::doubles::MockX11>::~NiceMock()':
/usr/include/gmock/gmock-nice-strict.h:149:(.text._ZN7testing8NiceMockIN3mir4test7doubles7MockX11EED2Ev[_ZN7testing8NiceMockIN3mir4test7doubles7MockX11EED5Ev]+0x18): undefined reference to `mir::test::doubles::MockX11::~MockX11()'
/usr/bin/ld: tests/unit-tests/CMakeFiles/mir_umock_unit_tests.dir/graphics/test_platform_prober.cpp.o: in function `testing::NiceMock<mir::test::doubles::MockX11>::NiceMock()':
/usr/include/gmock/gmock-nice-strict.h:158:(.text._ZN7testing8NiceMockIN3mir4test7doubles7MockX11EEC2Ev[_ZN7testing8NiceMockIN3mir4test7doubles7MockX11EEC5Ev]+0x25): undefined reference to `mir::test::doubles::MockX11::MockX11()'
```</issue_description>

<agent_instructions>Make the X11 test conditional on the `MIR_PLATFORM` definition including `x11`</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

• Fixes test_platform_prober assumes the x11 platform is built #4635

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Saviq]

@copilot while here, there's tests that also unconditionally, expect the wayland platform to be built, can you add a guard for them, too, please?

[Copilot]

@copilot while here, there's tests that also unconditionally, expect the wayland platform to be built, can you add a guard for them, too, please?

Done in 7f0bda7. Added guards for:

• enable_host_wayland() method with #if defined(MIR_BUILD_PLATFORM_WAYLAND)
• 2 Wayland-only tests
• 6 tests requiring both X11 and Wayland with #if defined(MIR_BUILD_PLATFORM_X11) && defined(MIR_BUILD_PLATFORM_WAYLAND)

[AlanGriffiths]

@copilot you also need to define MIR_BUILD_PLATFORM_WAYLAND when it is enabled in the build. See tests/unit-tests/CMakeLists.txt:16 for the similar MIR_BUILD_PLATFORM_X11 definition

[Saviq]

@copilot please work on the above.

[Copilot]

Done in 8ea7f63. Added add_compile_definitions(MIR_BUILD_PLATFORM_WAYLAND) in tests/unit-tests/CMakeLists.txt following the same pattern as X11.

[github-actions]

TICS Quality Gate

✔️ Passed

No changed files applicable for TICS analysis quality gating.

TICS / TICS / Run TICS analysis