Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail action to set or get incorrect user password #245

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Fail action to set or get incorrect user password #245

merged 4 commits into from
Jun 30, 2023

Conversation

shayancanonical
Copy link
Contributor

Issue

We are raising an exception when an invalid username is passed to the get-password or set-password action.

Solution

Use event.fail to return a more meaningful message (instead of raising an exception).

@shayancanonical shayancanonical merged commit 3bdf012 into main Jun 30, 2023
@shayancanonical shayancanonical deleted the fix/get_password branch June 30, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

@paulomach paulomach paulomach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shayancanonical @paulomach @taurus-forever @carlcsaposs-canonical