DPE-915 fix storage re-use bug #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
requested review from
shayancanonical,
carlcsaposs-canonical and
taurus-forever
carlcsaposs-canonical
requested changes
Jun 28, 2023
carlcsaposs-canonical
approved these changes
Jun 28, 2023
taurus-forever
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Failing to reuse previously storage on the charm.
Solution
If data directory is populated with mysql typical data, the charm tries to use start mysqld and rejoin the unit to the cluster.
Note 1: The
unit-configuredunit peer key, that indicate if a unit was already configured, was replaced with a method to check the mysql data directory directly.Note 2: case there's a
clusteradminpassword rotation before the scale up, joining the unit will fail, since the passwords will be out of sync. There's a backlog task (dpe-2186) to track this scenario.