Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPE-2277 Fixes for network partition test #272

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

paulomach
Copy link
Contributor

Issue

Flakiness on the network partition test

Solution

  • ensure chaos-mesh availability before test
  • fixes destroy script
  • function scoped

* ensure chaos-mesh availability before test
* fixes destroy script
* function scoped
@paulomach paulomach marked this pull request as ready for review August 8, 2023 23:38
taurus-forever
taurus-forever previously approved these changes Aug 9, 2023
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paulomach paulomach merged commit 0e6cafe into main Aug 9, 2023
13 checks passed
@paulomach paulomach deleted the fix/chaos-mesh-fixes branch August 9, 2023 13:17
@paulomach paulomach changed the title Fixes for network partition test DPE-2277 Fixes for network partition test Aug 10, 2023
shayancanonical added a commit that referenced this pull request Aug 16, 2023
Port over autogeneration of config values from the vm charm

Autogenerate config values for the mysql legacy relation

Add upterm session to debug failing integration test

Always set up upterm session

Pass essential env with built charm to upterm session

Fix minor bugs + remove upterm github action step

Run format

[upload-charm-docs] Migrate charm docs (#266)

* 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md'

* 'modified: docs/explanation/e-legacy-charm.md,docs/index.md'

* 'modified: docs/how-to/h-deploy-gke.md'

---------

Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com>

DPE-2068 use kill-delay (#258)

* use kill-delay

* update requirements and delay time

DPE-2225 using allocable memory instead of `free` (#256)

* using allocable memory instead of `free`

* use loose opt modifier

* merged from vm

* remove comment

* fix memory units

* set missing trust and testing profile in test

* adjust for low memory

* test change for ci

* fix function call

* typing fixes

* test wait for maintenance of instance before asserting recovery

* extra wait step

* strip trailing newline

* non-active

Fixes for network partition test (#272)

* fixes for chaos-mesh

* ensure chaos-mesh availability before test
* fixes destroy script
* function scoped

* address pr comment

* fix call

Port peer juju secret implementation from the vm charm (#263)

Upgrade mysql (v0.38) and tls (v0.2) charm libs + minor adjustments

[MISC] Revert change on Discourse Sync action (#265)

Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com>

[upload-charm-docs] Migrate charm docs (#266)

* 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md'

* 'modified: docs/explanation/e-legacy-charm.md,docs/index.md'

* 'modified: docs/how-to/h-deploy-gke.md'

---------

Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com>

DPE-2068 use kill-delay (#258)

* use kill-delay

* update requirements and delay time

DPE-2225 using allocable memory instead of `free` (#256)

* using allocable memory instead of `free`

* use loose opt modifier

* merged from vm

* remove comment

* fix memory units

* set missing trust and testing profile in test

* adjust for low memory

* test change for ci

* fix function call

* typing fixes

* test wait for maintenance of instance before asserting recovery

* extra wait step

* strip trailing newline

* non-active

Pin python dependencies with Poetry (#273)

[MISC] Switch maintainers to the DPE mailing list (#269)

* Switch maintainers to the DPE mailing list

* Update metadata.yaml

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

---------

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

Pin charmcraft to 2.3.0 in release.yaml to fix build (#276)

charmcraft pinned to 2.3.0 in integration test build but not release build

canonical/charmcraft#1179

Add missing group markers (#278)

Leftover from #273

No integration tests were running since no groups were collected

Address PR feedback
shayancanonical added a commit that referenced this pull request Aug 17, 2023
Port over autogeneration of config values from the vm charm

Autogenerate config values for the mysql legacy relation

Add upterm session to debug failing integration test

Always set up upterm session

Pass essential env with built charm to upterm session

Fix minor bugs + remove upterm github action step

Run format

[upload-charm-docs] Migrate charm docs (#266)

* 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md'

* 'modified: docs/explanation/e-legacy-charm.md,docs/index.md'

* 'modified: docs/how-to/h-deploy-gke.md'

---------

Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com>

DPE-2068 use kill-delay (#258)

* use kill-delay

* update requirements and delay time

DPE-2225 using allocable memory instead of `free` (#256)

* using allocable memory instead of `free`

* use loose opt modifier

* merged from vm

* remove comment

* fix memory units

* set missing trust and testing profile in test

* adjust for low memory

* test change for ci

* fix function call

* typing fixes

* test wait for maintenance of instance before asserting recovery

* extra wait step

* strip trailing newline

* non-active

Fixes for network partition test (#272)

* fixes for chaos-mesh

* ensure chaos-mesh availability before test
* fixes destroy script
* function scoped

* address pr comment

* fix call

Port peer juju secret implementation from the vm charm (#263)

Upgrade mysql (v0.38) and tls (v0.2) charm libs + minor adjustments

[MISC] Revert change on Discourse Sync action (#265)

Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com>

[upload-charm-docs] Migrate charm docs (#266)

* 'modified: docs/explanation/e-flowcharts.md,docs/explanation/e-interfaces.md,docs/index.md,docs/how-to/h-enable-monitoring.md // new: docs/explanation/e-legacy-charm.md,docs/how-to/h-deploy-gke.md'

* 'modified: docs/explanation/e-legacy-charm.md,docs/index.md'

* 'modified: docs/how-to/h-deploy-gke.md'

---------

Co-authored-by: upload-charms-docs-bot <upload-charms-docs-bot@users.noreply.github.com>

DPE-2068 use kill-delay (#258)

* use kill-delay

* update requirements and delay time

DPE-2225 using allocable memory instead of `free` (#256)

* using allocable memory instead of `free`

* use loose opt modifier

* merged from vm

* remove comment

* fix memory units

* set missing trust and testing profile in test

* adjust for low memory

* test change for ci

* fix function call

* typing fixes

* test wait for maintenance of instance before asserting recovery

* extra wait step

* strip trailing newline

* non-active

Pin python dependencies with Poetry (#273)

[MISC] Switch maintainers to the DPE mailing list (#269)

* Switch maintainers to the DPE mailing list

* Update metadata.yaml

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

---------

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

Pin charmcraft to 2.3.0 in release.yaml to fix build (#276)

charmcraft pinned to 2.3.0 in integration test build but not release build

canonical/charmcraft#1179

Add missing group markers (#278)

Leftover from #273

No integration tests were running since no groups were collected

Address PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants