Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPE-4613 Test for multi-relation scale in/out #489

Merged
merged 12 commits into from
Sep 12, 2024
Merged

DPE-4613 Test for multi-relation scale in/out #489

merged 12 commits into from
Sep 12, 2024

Conversation

paulomach
Copy link
Contributor

@paulomach paulomach commented Aug 21, 2024 •
edited
Loading

Issue #432 is not easily reproducible.

This PR tries to reproduce the use case, using multiple applications connected to a single cluster.

@paulomach paulomach changed the title test for multiple relations being scaled in/out together DPE-4613 Test for multi-relation scale in/out Aug 21, 2024
@taurus-forever
Copy link
Contributor

taurus-forever commented Aug 22, 2024 •
edited
Loading

@paulomach The test passed, and looks solid.
Proposal: deploy mysql db 3 units and random(1-3) units of the router.

More IPs + more events inside.

Also, is profile=production used on purpose here?

@paulomach
Copy link
Contributor Author

@paulomach The test passed, and looks solid. Proposal: deploy mysql db 3 units and random(1-3) units of the router.

More IPs + more events inside.

Also, is profile=production used on purpose here?

It's on testing.

I was out to replicate sunbeam deployment size + simultaneous scale in/out to catch their issue, but it may be helpful to exaggerate it here.

carlcsaposs-canonical
carlcsaposs-canonical approved these changes Aug 23, 2024
View reviewed changes
tests/integration/test_multi_relations.py Outdated
trust=True,
)

for i in range(1, SCALE_OUT + 1):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would start at 0 to make your life easier

taurus-forever
taurus-forever approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would also use 3 units for router (+ some test app also for 3 units.)

One performance recomentation here due to Inserts auto-start on test-app.

tests/integration/test_multi_relations.py Show resolved Hide resolved
tests/integration/test_multi_relations.py Show resolved Hide resolved
@paulomach paulomach marked this pull request as ready for review August 26, 2024 13:35
@shayancanonical
Copy link
Contributor

May be we can add a couple more mysql-test-app applications and router applications to see if we run into #476. Thoughts?

@paulomach paulomach merged commit a0d3948 into main Sep 12, 2024
86 of 87 checks passed
@paulomach paulomach deleted the feature/dpe-4613-router-metadata-gone branch September 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

@shayancanonical shayancanonical shayancanonical approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulomach @taurus-forever @shayancanonical @carlcsaposs-canonical