[DPE-4861] Add test to ensure correct k8s endpoints created for clusters with the same name #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
paulomach
reviewed
Sep 18, 2024
|
|
||
| @pytest.mark.group(1) | ||
| @pytest.mark.abort_on_fail | ||
| async def test_labeling_of_k8s_endpoints(ops_test: OpsTest): |
There was a problem hiding this comment.
the one thing to dispute here is the test being under ha tests, but I guess it's due usage of helpers, and not about being ha. we may need to shuffle some of the helpers for organization sake
There was a problem hiding this comment.
agreed, let's rearrange furniture in a separate PR allowing a better classification of integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are missing an integration test for #501
Solution
Add integration test