Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement response controller for logging middleware #101

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat: implement response controller for logging middleware #101

merged 2 commits into from
Nov 12, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Sep 27, 2024 •
edited
Loading

Description

This change implements the response controller for the logging middleware as mentioned in #84.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 requested a review from a team as a code owner September 27, 2024 10:33
@kayra1 kayra1 marked this pull request as draft September 27, 2024 10:33
@saltiyazan
Copy link
Contributor

@kayra1 is this PR being worked on?

@kayra1
Copy link
Contributor Author

kayra1 commented Nov 11, 2024

yes

@kayra1 kayra1 marked this pull request as ready for review November 11, 2024 08:05
@kayra1 kayra1 merged commit 536aaaa into main Nov 12, 2024
13 checks passed
@kayra1 kayra1 deleted the response-controller branch November 12, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltiyazan saltiyazan saltiyazan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayra1 @saltiyazan