Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include err value in test errors #85

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: include err value in test errors #85

merged 1 commit into from
Sep 20, 2024

Conversation

gruyaume
Copy link
Collaborator

Description

Include err value in test errors.

Here we address one of the major concerns from Ben review's (#84 ).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruyaume gruyaume requested a review from a team as a code owner September 20, 2024 11:38
@gruyaume gruyaume mentioned this pull request Sep 20, 2024
Open
@gruyaume
chore: include err value in test errors
d5a7e29 
Signed-off-by: guillaume <guillaume.belanger27@gmail.com>
@gruyaume gruyaume merged commit 651d7fc into main Sep 20, 2024
13 checks passed
@gruyaume gruyaume deleted the dev-feedback branch September 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruyaume @ghislainbourgeois