Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6249] Add max_locks_per_transaction config option #804

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Dec 18, 2024

Issue

The max_locks_per_transaction PostgreSQL setting is not available for users to set.

Solution

Create a config option to expose it to the users.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.54%. Comparing base (efa20a4) to head (2f94704).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/config.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
- Coverage   75.55%   75.54%   -0.01%     
==========================================
  Files          12       12              
  Lines        3105     3112       +7     
  Branches      464      465       +1     
==========================================
+ Hits         2346     2351       +5     
- Misses        620      621       +1     
- Partials      139      140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…r-transaction

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@marceloneppel marceloneppel marked this pull request as ready for review January 10, 2025 14:24
@marceloneppel marceloneppel changed the title [DPE-6249] Add max_locks_per_transaction config option [DPE-6249] Add max_locks_per_transaction config option Jan 10, 2025
@sinclert-canonical
Copy link
Contributor

👋🏻 We just merged a PR updating all typing syntax to Python 3.10+. Please remember to update this PR accordingly.

…r-transaction

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@marceloneppel
Copy link
Member Author

👋🏻 We just merged a PR updating all typing syntax to Python 3.10+. Please remember to update this PR accordingly.

Thanks for pointing that out, @sinclert-canonical! I updated this PR with the changes from the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants