[MISC] Define charm utility properties #842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
force-pushed
the
sinclert/charm-data-properties
branch
from
09dc015 to
99586b8
Compare
sinclert-canonical
force-pushed
the
sinclert/charm-data-properties
branch
from
99586b8 to
b339193
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
+ Coverage 75.53% 75.63% +0.09%
==========================================
Files 12 12
Lines 3115 3127 +12
Branches 466 466
==========================================
+ Hits 2353 2365 +12
Misses 621 621
Partials 141 141 ☔ View full report in Codecov by Sentry. |
Comment on lines
+512
to
+516
| if not (self.charm.is_unit_stopped or self._is_following_promoted_cluster()) or not all( | ||
| "stopped" in self.charm._peers.data[unit] | ||
| or self.charm._peers.data[unit].get("unit-promoted-cluster-counter") | ||
| == self._get_highest_promoted_cluster_counter_value() | ||
| for unit in {*self.charm._peers.units, self.charm.unit} | ||
| for unit in self.charm._peers.units |
There was a problem hiding this comment.
Review these lines carefully. I think I preserved the original logic
sinclert-canonical
requested review from
dragomirp,
marceloneppel and
lucasgameiroborges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a set of charm properties to reduce the chance of introducing typos when checking for specific keys in the app / unit data-bags, as well as reduce the cognitive load of logical statements.
The new properties are:
is_cluster_restoring_backup.is_cluster_restoring_to_time.is_unit_departingis_unit_stopped.The existing properties, now used throughout the codebase are:
is_cluster_initialised.