Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Split topology script #853

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Conversation

sinclert-canonical
Copy link
Contributor

This PR ports part of the changes introduced in this PR VM counter-part, by creating a folder scripts folder, and moving there the rotate_logs.py script. This change is proposed in preparation for the addition of a new LDAP-Sync pebble service stand-along script, which does not belong alongside the rest of the src logic.

Additional notes:

Please review the couple of instances where the script is referenced within /home/postgres folder. Not sure if my proposed changes affect that.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (4b101f4) to head (2b8e10c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   75.56%   75.56%           
=======================================
  Files          12       12           
  Lines        3127     3127           
  Branches      467      467           
=======================================
  Hits         2363     2363           
  Misses        623      623           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sinclert-canonical sinclert-canonical merged commit 297d181 into main Feb 11, 2025
99 checks passed
@sinclert-canonical sinclert-canonical deleted the sinclert/split-scripts branch February 11, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants