Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Confirmation modal can be very narrow #976 #1018

Closed
wants to merge 4 commits into from
Closed

fix: Confirmation modal can be very narrow #976 #1018

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89d6035
fix: Confirmation modal can be very narrow #976
nadeem-R17 Jan 18, 2024
65c05e6
Updated confirmation modal width issue PR
nadeem-R17 Jan 22, 2024
deffafb
Updated confirmation modal width issue PR
nadeem-R17 Jan 22, 2024
0dd65ce
Merge pull request #1 from nadeem-R17/fix-cnf-modal-width
nadeem-R17 Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/ConfirmationModal/ConfirmationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ export const ConfirmationModal = ({
}
{...props}
>
{children}
<div style={{ minWidth: '480px' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is problematic, if the screen size is lower than 480px.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing that to my attention. I've addressed the issue by implementing an adjustable minWidth for the content, taking into consideration screen sizes lower than 480px. If you have any further suggestions or if additional changes are needed, please feel free to let me know.

ConfirmationModal.-.Docs.Storybook.-.Google.Chrome.2024-01-22.11-04-04.mp4

{children}
</div>
</Modal>
);
};
Expand Down