Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiselect component #1036

Merged

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Feb 2, 2024

Done

This PR adds a component that already has been implemented in maas-react-components. It seems that at least one other project needs this, which means it's time to upstream it to react-components

  • feat: add multiselect component

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Go to MultiSelect component page in storybook
  • Ensure you can open and close all variants without issues

Screenshots

Google Chrome screenshot 001498@2x

@webteam-app
Copy link

Demo starting at https://react-components-1036.demos.haus

Copy link

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, this looks good!

@petermakowski petermakowski merged commit d8a13a3 into canonical:main Feb 2, 2024
8 checks passed
@petermakowski petermakowski deleted the feat-multiselect-component branch February 2, 2024 15:26
Copy link

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 0.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants