Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Require the review of Percy visual tests #1056

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Mar 21, 2024

Done

  • Adds a CI check that enforces Percy review and adding Review: Percy +1 label.
  • Adds a Review: Percy needed automatically if any files in src are changed.

QA

  • Check that there is no Review: Percy +1 label on the PR.
  • Check that CI is failing on "PR Percy Review Label Required" job
  • Find a bot comment describing why merging is blocked that describes what to do
  • Follow the comment instructions
  • After reviewing Percy, add Review: Percy +1 label
  • Make sure CI passes

@webteam-app
Copy link

Demo starting at https://react-components-1056.demos.haus

@bartaz bartaz changed the title Require the review of Percy visual tests ci: Require the review of Percy visual tests Mar 21, 2024
@bartaz
Copy link
Member Author

bartaz commented Apr 4, 2024

Ah, thanks, forgot about this one :)

@bartaz bartaz merged commit 1f0ae65 into main Apr 4, 2024
13 of 16 checks passed
@bartaz bartaz deleted the percy-label-checks branch April 4, 2024 15:53
@lorumic
Copy link
Contributor

lorumic commented Apr 4, 2024

Ah, thanks, forgot about this one :)

I rebased #1063 on main now, so it can be seen in "real" action there (meaning that some actual differences in Percy are expected for that PR). :)
I hope this will not discourage people from reviewing it! 😅

Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 0.51.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants