Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): reset value to an empty string #1070

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Apr 16, 2024

Done

  • Allow setting the value to an empty string. Otherwise, the previous value isn't updated.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

You should be able to replicate this in a simplified example such as the one in the issue (#1068).

Percy steps

No visual change

Fixes

Fixes: #1068

@webteam-app
Copy link

@andesol
Copy link
Contributor Author

andesol commented Apr 18, 2024

@lorumic Ready!

Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andesol andesol merged commit 67d2e42 into canonical:main Apr 18, 2024
10 checks passed
@andesol andesol deleted the fix-textarea-empty-string branch April 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textarea doesn't update value when it's an empty string
3 participants