Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip should not reopen when target element is not hovered anymore #1074

Merged
merged 1 commit into from
Apr 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/Tooltip/Tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ export const adjustForWindow = (
* @param positionElementClassName An optional class to apply to the element that wraps the children.
* @param tooltipClassName An optional class to apply to the tooltip message element.
* @param zIndex The z-index value of the tooltip message element.
* @param delay Delay in ms after which Tooltip will appear (defaults to 350ms).
*/
const Tooltip = ({
autoAdjust = true,
Expand Down Expand Up @@ -305,9 +306,15 @@ const Tooltip = ({
};

const delayedOpenPortal: MouseEventHandler = useCallback(() => {
if (isOpen) {
return;
}
if (timer) {
clearTimeout(timer);
}
const timeout = setTimeout(() => openPortal(), delay);
setTimer(timeout);
}, [delay, openPortal]);
}, [delay, openPortal, timer, isOpen]);

return (
<>
Expand Down
Loading