fix: make EmptyState implementation consistent with Vanilla Framework

[vladimir-cucu]

Done

• Made EmptyState component design be consistent with No content Empty State in Vanilla Framework.

Fixes

• EmptyState implementation inconsistency with Vanilla Framework #1071

Screenshots

[webteam-app]

Demo

Jenkins

demos.haus

[vladimir-cucu]

Checked the changes in percy and am not sure why some of them are there. Checked locally the storybook differences between main and my branch, and couldn't replicate the changes spotted by percy, apart from the 2 changes related to EmptyState component.

[bartaz]

Checked the changes in percy and am not sure why some of them are there. Checked locally the storybook differences between main and my branch, and couldn't replicate the changes spotted by percy, apart from the 2 changes related to EmptyState component.

Yes, it looks like the diff is made by older version of main branch for some reason. I'll have a look if I can restart those to get them cleaned up.

[bartaz]

@vladimir-cucu I think the Percy issue is caused by the fact that your branch is likely not created from freshest main, so you are couple commits behind, making your snapshots show older versions of some components that changed in main branch.

Could you fetch and rebase on top of fresh main and push again? This should hopefully fix that.

[bartaz]

LGTM, thanks!

[bartaz]

Icons shouldn't be used this way. They were not designed to be scaled that much up (and weird things may start happening).

This one for example doesn't scale on small screens due to missing max-width that we have on img:

Ideally, this should only be used with images. Would be good not to document an example with a bad pattern like this.

Maybe let's use this one from assets: https://assets.ubuntu.com/v1/c17e0d92-container.svg

[vladimir-cucu]

Thanks for the comment! Didn't know about this. The default example has the exact same issue with scaling on small screens. I've used the image from the assets for the default example as well.

[vladimir-cucu]

@vladimir-cucu I think the Percy issue is caused by the fact that your branch is likely not created from freshest main, so you are couple commits behind, making your snapshots show older versions of some components that changed in main branch.

Could you fetch and rebase on top of fresh main and push again? This should hopefully fix that.

@bartaz After rebase on top of main with latest changes and 2 more placeholder PRs to restart percy, it finally shows the expected changes!

[bartaz]

LGTM, thanks!

[github-actions]

🎉 This PR is included in version 0.53.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀