Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): allow to use a ReactNode as title for an accordion #1100

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Jun 20, 2024

Done

  • Changed the type of the title prop of the AccordionSection to be ReactNode instead of string. Since ReactNode is a superset of string, it is automatically backward-compatible and non-breaking.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Check the newly added accordion example in Storybook.

Percy steps

  • One example was added to the accordion page of the Storybook, so that is likely to be flagged as a diff by Percy. Nothing else should be flagged.

@webteam-app
Copy link

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lorumic lorumic merged commit f704e2e into canonical:main Jun 20, 2024
13 of 16 checks passed
@lorumic lorumic deleted the accordion-custom-heading branch June 20, 2024 10:30
Copy link

🎉 This PR is included in version 0.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants