-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Select): Add support for required attribute #1110
base: main
Are you sure you want to change the base?
Conversation
kaiweike is not a collaborator of the repo |
This PR is being prevented from merging because it needs to be reviewed on Percy. Go to Percy, find the build relevant to this PR and check if it looks as expected. Once it's approved, add the label |
I encountered an "Access Denied" issue while trying to access the Percy test results. It seems I don't have the necessary permissions. Could someone please assist with granting me the appropriate access? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some lint failures on this PR.
@@ -119,3 +125,43 @@ export const SelectMultiple: Story = { | |||
|
|||
name: "Select multiple", | |||
}; | |||
|
|||
export const RequiredSelect: Story = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this prop requires an isolated example.
Done
required
attribute in theSelect
component, ensuring it is correctly passed down to the<select>
element.required
attribute.required
attribute behaves as expected, both when set and not set.QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
Select
component with therequired
attribute.required
attribute allows the form to be submitted without selecting an option.Percy steps
Fixes
Fixes: #1045