Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace internals of MultiSelect with ContextualMenu #1117

Merged
merged 1 commit into from
Aug 20, 2024
Merged

refactor: replace internals of MultiSelect with ContextualMenu #1117

merged 1 commit into from
Aug 20, 2024

Conversation

huwshimi
Copy link
Collaborator

@huwshimi huwshimi commented Aug 20, 2024 •
edited
Loading

Done

  • Replace internals of MultiSelect with ContextualMenu so it uses a portal to fix overflow: hidden issues.

QA

  • Go to the MultiSelect demo.
  • Open the dropdown and it shouldn't get cut off by the frame around the example.

Fixes

Fixes: #1116.

@webteam-app
Copy link

Demo

Jenkins

demos.haus

vladimir-cucu
vladimir-cucu approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@vladimir-cucu vladimir-cucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@huwshimi huwshimi merged commit 92ff5f6 into canonical:main Aug 20, 2024
15 of 18 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-cucu vladimir-cucu vladimir-cucu approved these changes

Assignees
No one assigned
Labels
released Review: Code +1 Review: Percy +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiSelect cut off in panel
3 participants
@huwshimi @webteam-app @vladimir-cucu