Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update SideNavigationLink component's prop type #1133

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: Update SideNavigationLink component's prop type #1133

merged 1 commit into from
Sep 19, 2024

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Sep 18, 2024 •
edited
Loading

Done

  • Update SideNavigationLink component's prop type to handle props properly.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: # .

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@aaryanporwal aaryanporwal changed the title fix: Update SideNavigationLink component to include onClick prop fix: Update SideNavigationLink component's prop type Sep 19, 2024
huwshimi
huwshimi approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the improvement.

@aaryanporwal aaryanporwal merged commit 47d1030 into canonical:main Sep 19, 2024
12 of 16 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aaryanporwal aaryanporwal deleted the fix-sidenav-onclick branch September 19, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

@edlerd edlerd Awaiting requested review from edlerd

Assignees
No one assigned
Labels
released Review: Code +1 Review: Percy +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaryanporwal @webteam-app @huwshimi @edlerd