feat: add stepper and step components #1134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
|
This PR is being prevented from merging because it needs to be reviewed on Percy. Go to Percy, find the build relevant to this PR and check if it looks as expected. Once it's approved, add the label |
1 similar comment
|
This PR is being prevented from merging because it needs to be reviewed on Percy. Go to Percy, find the build relevant to this PR and check if it looks as expected. Once it's approved, add the label |
edlerd
reviewed
Sep 20, 2024
Comment on lines
+3
to
+10
| .p-list__item { | ||
| padding-bottom: 0; | ||
| padding-top: 0; | ||
| } | ||
|
|
||
| .p-inline-list { | ||
| display: flex; | ||
| } |
There was a problem hiding this comment.
Those look like standard vanilla classes, which we shouldn't override globally.
I think best is
- to namespace all selectors in this file with a wrapper and
- target only custom classes
| /** | ||
| * Icon to display in the step. Specify "number" if the index should be displayed. | ||
| */ | ||
| iconName: string; |
There was a problem hiding this comment.
Should we reference the icon names ValueOf<typeof ICONS> | string | "number" here to allow autocomplete?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
The current stepper component is of the standard size outlined in the spec. If required, the large size can be added at a later time.
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Percy steps
Fixes
Fixes: # .