Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove unnecessary Percy label CI check #1140

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Sep 26, 2024

Done

Now that Percy CI check is fully integrated we can remove the workflow that checks for a label.

@webteam-app
Copy link

@jmuzina
Copy link
Member

jmuzina commented Sep 26, 2024

As this workflow runs on pull_request_target, I think you won't see the changes from this PR until this is merged into main. So the workflow ran, but it shouldn't run on future PRs.

@jmuzina
Copy link
Member

jmuzina commented Sep 26, 2024

FYI, I added the Percy integration status check as a required PR check - it should pass here as soon as Percy finishes running.

@bartaz bartaz merged commit bcec9c1 into main Sep 26, 2024
10 checks passed
@bartaz bartaz deleted the remove-percy-label-workflow branch September 26, 2024 15:43
Copy link

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants