Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix broken type declarations downstream imports #1141

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Sep 26, 2024

Done

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Checkout this PR
  • Link packages with yarn link-packages in the react components repo.
  • Checkout some project that depends on React Components.
  • Try the following imports and verify they work as expected.
import { MainTable } from "@canonical/react-components"; // a component
import { MainTableRow } from "@canonical/react-components/dist/components/MainTable/MainTable"; // a type

Percy steps

  • No visual changes expected.

Fixes

Fixes: https://chat.canonical.com/canonical/pl/unjxx7ab8pgf3n9dncb7ir8anc

@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review September 26, 2024 17:42
@jmuzina jmuzina changed the title wip: Fix broken type declarations downstream imports fix: Fix broken type declarations downstream imports Sep 26, 2024
@jmuzina jmuzina merged commit 3879dc0 into canonical:main Sep 26, 2024
9 checks passed
@jmuzina jmuzina deleted the fix-type-decl-import branch September 26, 2024 19:08
Copy link

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants