Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): Icons updates #1152

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcslayer
Copy link
Contributor

Done

Implement enhancements for Icon stories:

  • Add all icons from vanilla-framework to constants
  • Enable icon selection for Base and Social sections
  • Add Standard story allowing icon selection
  • Add Additional story with options for icon selection and descriptions
  • Add a story that includes all available icons for use

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: # .

@webteam-app
Copy link

mcslayer is not a collaborator of the repo

@mcslayer mcslayer changed the title Icons updates docs(storybook): Icons updates Oct 28, 2024
@bartaz
Copy link
Member

bartaz commented Oct 30, 2024

There are errors in src/components/EmptyState/EmptyState.stories.tsx cased by missing externalLink icon (caused by rename).

@mcslayer mcslayer force-pushed the icons-stories branch 2 times, most recently from 15d77b3 to 9a86333 Compare October 30, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants