Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Update all packages to latest version #1157

Closed
wants to merge 2 commits into from

Conversation

mcslayer
Copy link
Contributor

@mcslayer mcslayer commented Oct 30, 2024

Done

  • Update all dependencies to the last version
    Screenshot 2024-10-30 at 22 27 19
  • After this update, I've got more lint errors. So I fixed them in components:
    • ContextualMenu.stories.tsx — problem with using nodes from the fill method without keys. Fixed by 3 separate paragraphs
    • ModularTable.stories.tsx — problem with using div in p. Fixed by adding a break to markdown for separate code block and paragraph
    • SideNavigationItem.stories.tsx — problem with using li in li and with icon's place. Fixed by using args from stories in items props
    • Textarea.tsx — problems with using defaultValue in spread ...props, because after that we have controlled and uncontrolled textarea at the same time (value we get from state, defaultValue we get from ...props). Fixed by using separate prop defaultValue.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: # .

@webteam-app
Copy link

mcslayer is not a collaborator of the repo

@bartaz
Copy link
Member

bartaz commented Nov 1, 2024

Thank you, but we generally don't manage dependency updates manually. We rely on renovate to trigger update PRs for us.

But thanks for noticing that many of them were outdated. I poked on renovate to update them (#1159).

@jmuzina jmuzina closed this Nov 1, 2024
@mcslayer
Copy link
Contributor Author

mcslayer commented Nov 1, 2024

:( okay

Anyway, I suggest taking a closer look at a few specific points:

  • ContextualMenu.stories.tsx — problem with using nodes from the fill method without keys. Fixed by 3 separate paragraphs
  • ModularTable.stories.tsx — problem with using div in p. Fixed by adding a break to markdown for separate code block and paragraph
  • SideNavigationItem.stories.tsx — problem with using li in li and with icon's place. Fixed by using args from stories in items props
  • Textarea.tsx — problems with using defaultValue in spread ...props, because after that we have controlled and uncontrolled textarea at the same time (value we get from state, defaultValue we get from ...props). Fixed by using separate prop defaultValue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants