Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TablePaginationControls): Hide total pages text when page input is hidden #1158

Conversation

fasih-mehmood
Copy link
Contributor

Done

  • Hide the total pages text when showPageInput is set to false

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Set showPageInput to false in the ControlsOnly example of TablePagination.stories.tsx.
  • You should not see any text between the buttons in the Controls Only example of TablePagination.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: https://chat.canonical.com/canonical/pl/6paertj3fpd3jkutj7j69715jw

@webteam-app
Copy link

Copy link
Collaborator

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@fasih-mehmood fasih-mehmood merged commit a853161 into canonical:main Nov 1, 2024
8 checks passed
@fasih-mehmood fasih-mehmood deleted the fix-table-pagination-controls-page-text branch November 1, 2024 00:10
Copy link

github-actions bot commented Nov 1, 2024

🎉 This PR is included in version 1.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants